containerd / nydus-snapshotter

A containerd snapshotter with data deduplication and lazy loading in P2P fashion
https://nydus.dev/
Apache License 2.0
173 stars 100 forks source link

pkg/auth: remove CRI Alpha API #611

Closed thaJeztah closed 3 months ago

thaJeztah commented 3 months ago

CRI v1alpha2 is deprecated since containerd 1.7: https://github.com/containerd/containerd/blob/v1.7.0/RELEASES.md#deprecated-features

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 34.31%. Comparing base (261dd69) to head (f46b631). Report is 1 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/611/graphs/tree.svg?width=650&height=150&src=pr&token=R3RX5WX6R1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/611?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) ```diff @@ Coverage Diff @@ ## main #611 +/- ## ========================================== - Coverage 34.36% 34.31% -0.05% ========================================== Files 65 65 Lines 6606 6598 -8 ========================================== - Hits 2270 2264 -6 + Misses 4021 4020 -1 + Partials 315 314 -1 ``` | [Files](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/611?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [pkg/auth/image\_proxy.go](https://app.codecov.io/gh/containerd/nydus-snapshotter/pull/611?src=pr&el=tree&filepath=pkg%2Fauth%2Fimage_proxy.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-cGtnL2F1dGgvaW1hZ2VfcHJveHkuZ28=) | `75.51% <100.00%> (+0.07%)` | :arrow_up: |
thaJeztah commented 3 months ago

@imeoer rebased, and I included some of the fixes from @apostasie (from https://github.com/containerd/nydus-snapshotter/pull/604) in this patch, adding them as co-author.

My goal with these sets of PRs was to see if we could have a release with the new modules in place (removing the ones deprecated in containerd) before this module moves to v2, so that I can update the version used in BuildKit in preparation of dependencies starting to move to containerd v2 (these module moves in containerd are intended to help with that transition to make sure a common module is used between v1 and v2 codebases).

:warning: Given that this PR removes some functionality, perhaps it warrants a v0.14.0 ❓ maybe tagging current main / https://github.com/containerd/nydus-snapshotter/pull/610 as v0.13.15 ?

imeoer commented 3 months ago

cc @changweige

thaJeztah commented 3 months ago

FWIW: I opened a draft PR to test current main branch to verify it all works ok in BuildKit in case doing a v0.13.15 from current main is an option;

imeoer commented 3 months ago

LGTM!

imeoer commented 3 months ago

v0.14.0 released, thanks! cc @thaJeztah @apostasie