Closed thaJeztah closed 3 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 34.31%. Comparing base (
261dd69
) to head (f46b631
). Report is 1 commits behind head on main.
@imeoer rebased, and I included some of the fixes from @apostasie (from https://github.com/containerd/nydus-snapshotter/pull/604) in this patch, adding them as co-author.
My goal with these sets of PRs was to see if we could have a release with the new modules in place (removing the ones deprecated in containerd) before this module moves to v2, so that I can update the version used in BuildKit in preparation of dependencies starting to move to containerd v2 (these module moves in containerd are intended to help with that transition to make sure a common module is used between v1 and v2 codebases).
:warning: Given that this PR removes some functionality, perhaps it warrants a v0.14.0 ❓ maybe tagging current main / https://github.com/containerd/nydus-snapshotter/pull/610 as v0.13.15 ?
cc @changweige
FWIW: I opened a draft PR to test current main branch to verify it all works ok in BuildKit in case doing a v0.13.15 from current main is an option;
LGTM!
v0.14.0 released, thanks! cc @thaJeztah @apostasie
CRI v1alpha2 is deprecated since containerd 1.7: https://github.com/containerd/containerd/blob/v1.7.0/RELEASES.md#deprecated-features