search

containerd / rust-extensions

Rust crates to extend containerd
https://containerd.io
Apache License 2.0
184 stars 73 forks source link

add Cargo.lock to fix too new version break build #317

Closed ningmingxiao closed 1 month ago

ningmingxiao commented 1 month ago

because ttrpc-compiler update to 0.6.3 will cause build error. now some tag and release version can't use cargo build (some package was updated).So it is necessary to add vendor or Cargo.lock to project.

@mxpv @Burning1020 can you review this pr ? Thank you.

mxpv commented 1 month ago

Cargo.lock would make more sense for binaries. I think we should start pinning ttrpc version in Cargo.toml (like ttrpc = "=exact_version") since there are breaking changes every now and then.

mxpv commented 1 month ago

I've pinned ttrpc versions. Going to close this one.