containerd / rust-extensions

Rust crates to extend containerd
https://containerd.io
Apache License 2.0
184 stars 73 forks source link

.github/workflows/ci: add machete to CI #319

Closed Mossaka closed 2 weeks ago

Mossaka commented 1 month ago

this will check if there are unused deps in this repo

mxpv commented 1 month ago

Try rebase?

Mossaka commented 1 month ago

Ah the issue was not about rebase. The error from cargo machete says

containerd-snapshots -- ./crates/snapshots/Cargo.toml:
    prost
containerd-client -- ./crates/client/Cargo.toml:
    prost

we probably want to ignore prost dependency as it's actually being used.

Mossaka commented 2 weeks ago

Can we merge this PR? @mxpv

mxpv commented 2 weeks ago

@Mossaka could you pls rebase against latest main? Looks like there is a CI issue that needs to be addressed first.

Mossaka commented 2 weeks ago

Looks like I need to rebase this one