containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

[0.6.0] ttrpc-codegen: Fix proto3's optional support #164

Closed Tim-Zhang closed 1 year ago

Tim-Zhang commented 1 year ago

Optional field was not generated right by protobuf-codegen-pure3@2.27.3. I have fixed the problem on version 2.28.1, so we can bump the protobuf-codegen-pure3 to 2.28.1 to fix the problem.

codecov[bot] commented 1 year ago

Codecov Report

Base: 11.68% // Head: 11.70% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (a42b31c) compared to base (025c235). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## 0.6.0 #164 +/- ## ========================================== + Coverage 11.68% 11.70% +0.01% ========================================== Files 13 13 Lines 1549 1547 -2 ========================================== Hits 181 181 + Misses 1368 1366 -2 ``` | [Impacted Files](https://codecov.io/gh/containerd/ttrpc-rust/pull/164?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [src/asynchronous/server.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2FzeW5jaHJvbm91cy9zZXJ2ZXIucnM=) | `0.00% <0.00%> (ø)` | | | [src/common.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/164/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2NvbW1vbi5ycw==) | `49.66% <0.00%> (+0.33%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Tim-Zhang commented 1 year ago

https://crates.io/crates/ttrpc-codegen/0.3.2 has been published