containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

Add comments for why VsockListener in async-server. #177

Closed Tim-Zhang closed 1 year ago

Tim-Zhang commented 1 year ago

The code introduced by #38 was confused and seems like unnecessary. During some test, it could be removed, but it was decided to be kept for the compatibility and vsock-specific features maybe used in the future.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.04 :tada:

Comparison is base (3522dac) 25.71% compared to head (476446f) 25.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #177 +/- ## ========================================== + Coverage 25.71% 25.76% +0.04% ========================================== Files 16 16 Lines 2399 2395 -4 ========================================== Hits 617 617 + Misses 1782 1778 -4 ``` | [Impacted Files](https://codecov.io/gh/containerd/ttrpc-rust/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [src/asynchronous/server.rs](https://codecov.io/gh/containerd/ttrpc-rust/pull/177?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2FzeW5jaHJvbm91cy9zZXJ2ZXIucnM=) | `0.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.