search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

CI: lock Rust version to 1.66 #179

Closed Tim-Zhang closed 1 year ago

Tim-Zhang commented 1 year ago

We've had enough with clippy errors happens with code untouched. And the clippy(1.68) suggestion about enum Default derive is conflict with lower Rust version(<1.66)

To avoid this problem we lock the rust version and make it steady.

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (476446f) 25.76% compared to head (34003e3) 25.76%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #179 +/- ## ======================================= Coverage 25.76% 25.76% ======================================= Files 16 16 Lines 2395 2395 ======================================= Hits 617 617 Misses 1778 1778 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jsturtevant commented 1 year ago

could another option be to bump the rust version but use a #[allow(clippy:<rule>)] with a comment that we want to support older versions of the tool chain? How far back do the older rust version need to be supported?

Tim-Zhang commented 1 year ago

@jsturtevant Not only for the problem we just met but also we want to do this long ago. Because we the developers need a stable expectation that unchanged code should pass the CI as it did last time.

We will increase the version manually when we need afterwards. Thanks!