containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

MAINTAINERS: add Tim Zhang and Lei Wang as member #188

Closed fuweid closed 1 year ago

fuweid commented 1 year ago

Tim Zhang(@Tim-Zhang) has meaningful contribution to the project and is the maintainer of project as collaborator. He should be added as member officially. I'd like to add him as COMMITTER.

And Lei Wang(@wllenyj) has been a active reviewer, but he is still collaborator. He should be added as member as well. So, I'd like to add him as REVIEWER.

Needs explicit LGTM from:

Signed-off-by: Wei Fu fuweid89@gmail.com


@containerd/committers @teawater @lifupan

wllenyj commented 1 year ago

LGTM

Tim-Zhang commented 1 year ago

LGTM, Thanks @fuweid

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (4661bd1) 24.39% compared to head (dde3298) 24.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #188 +/- ## ======================================= Coverage 24.39% 24.39% ======================================= Files 17 17 Lines 2529 2529 ======================================= Hits 617 617 Misses 1912 1912 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

Tim-Zhang commented 1 year ago

Mark it as WIP to avoid someone merge it before core committer's confirmation.

gnawux commented 1 year ago

LGTM

jsturtevant commented 1 year ago

Lgtm

Thanks for the reviews and feedback!

teawater commented 1 year ago

LGTM

fuweid commented 1 year ago

Ping @dmcgowan Please send invitation to Tim and Lei Wang. Thanks!

@wllenyj @Tim-Zhang Please ensure you are enable 2FA as well.

Tim-Zhang commented 1 year ago

@fuweid @dmcgowan I have received the invitation and have joined containerd successfully. Thank you both and Thank you all guys here for accepting me as a member.