search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

Update dependencies for the main ttrpc project #189

Closed jsturtevant closed 1 year ago

jsturtevant commented 1 year ago

Updates the dependencies for the main ttrpc project. This is in preparation for a release to include the Windows files in support for projects like the rust shim in https://github.com/containerd/rust-extensions/pull/139

jsturtevant commented 1 year ago

The nix dependency is failing due to:

error: use of deprecated enum `nix::sys::socket::SockAddr`: use SockaddrLike or SockaddrStorage instead
   --> src/common.rs:107:62

Is this something that should be addressed or should we move back to an older version and address later?

Tim-Zhang commented 1 year ago

The nix dependency is failing due to:

error: use of deprecated enum `nix::sys::socket::SockAddr`: use SockaddrLike or SockaddrStorage instead
   --> src/common.rs:107:62

Is this something that should be addressed or should we move back to an older version and address later?

I think we could adapt the new nix API by using SockaddrLike instead of SockAddr

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.03 :warning:

Comparison is base (dde3298) 24.39% compared to head (48cdc42) 24.36%.

:exclamation: Current head 48cdc42 differs from pull request most recent head fee3e00. Consider uploading reports for the commit fee3e00 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #189 +/- ## ========================================== - Coverage 24.39% 24.36% -0.03% ========================================== Files 17 17 Lines 2529 2532 +3 ========================================== Hits 617 617 - Misses 1912 1915 +3 ``` | [Impacted Files](https://app.codecov.io/gh/containerd/ttrpc-rust/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [src/common.rs](https://app.codecov.io/gh/containerd/ttrpc-rust/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2NvbW1vbi5ycw==) | `34.57% <0.00%> (-1.00%)` | :arrow_down: | | [src/error.rs](https://app.codecov.io/gh/containerd/ttrpc-rust/pull/189?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2Vycm9yLnJz) | `55.55% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jsturtevant commented 1 year ago

@Tim-Zhang I've update to use those API's.

Another option instead of boxing the trait would be to refactor some of these functions where make_socket are used. I don't know enough about the impact of Boxing to know if a bigger refactor of those functions makes sense or this is good enough.

Tim-Zhang commented 1 year ago

@jsturtevant I have some suggestions and I've just left a comment