search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

Release ttrpc: v0.8.0 #190

Closed jsturtevant closed 1 year ago

jsturtevant commented 1 year ago

Release ttrpc: v0.8.0. The main feature of this release is support for the Windows Synchronous server and client

This allows usage in projects like https://github.com/containerd/rust-extensions/pull/139

note

I don't know the projects release process but was hoping to start the conversation here. I am happy to help document the process as well.

Leaving in draft until #189 merges

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (dde3298) 24.39% compared to head (35a1337) 24.39%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #190 +/- ## ======================================= Coverage 24.39% 24.39% ======================================= Files 17 17 Lines 2529 2529 ======================================= Hits 617 617 Misses 1912 1912 ``` | [Impacted Files](https://app.codecov.io/gh/containerd/ttrpc-rust/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [src/error.rs](https://app.codecov.io/gh/containerd/ttrpc-rust/pull/190?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2Vycm9yLnJz) | `55.55% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jsturtevant commented 1 year ago

@Tim-Zhang @lifupan @wllenyj Any thoughts on a release?

wllenyj commented 1 year ago

LGTM

Tim-Zhang commented 1 year ago

@jsturtevant Should we merge Client::new_from_fd and Client::new methods before this mojor bump?

jsturtevant commented 1 year ago

@jsturtevant Should we merge Client::new_from_fd and Client::new methods before this mojor bump?

I was thinking a release with the depreciated function in it with [deprecated] tag allows folks to upgrade versions on their time without changes. In the next version we could remove the depreciated function giving one release to make the change.

If it is preferable to remove the function from one release to the next then let me know and I can drop it.

Tim-Zhang commented 1 year ago

@jsturtevant In my opinion, I prefer to remove the [deprecated] method and rename new_from_fd to new. The release is a major release so we don't need to consider compatible issues.

jsturtevant commented 1 year ago

@jsturtevant In my opinion, I prefer to remove the [deprecated] method and rename new_from_fd to new. The release is a major release so we don't need to consider compatible issues.

opened https://github.com/containerd/ttrpc-rust/pull/191

jsturtevant commented 1 year ago

@Tim-Zhang @mxpv Is there an additional step to release the crate? I am not seeing it on crates.io

mxpv commented 1 year ago

@Tim-Zhang @lifupan can you guys help with the new crate release?

Tim-Zhang commented 1 year ago

@jsturtevant @mxpv I have just released the version: https://crates.io/crates/ttrpc/0.8.0, sorry to be a bit slow to do it.

jsturtevant commented 1 year ago

Thanks! Would some automation help here? We recently automated this in Runwasi (https://github.com/containerd/runwasi/blob/main/.github/workflows/release.yml). Might help with long term maintenance