containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

Update client::new to return Result<Client> #191

Closed jsturtevant closed 1 year ago

jsturtevant commented 1 year ago

When introducing Windows support the client creation resulted in a Result being returned. This a breaking update for client::new in the client API.

Follow up to https://github.com/containerd/ttrpc-rust/pull/181 and https://github.com/containerd/ttrpc-rust/pull/190#issuecomment-1576001447

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: +0.10 :tada:

Comparison is base (48cdc42) 24.36% compared to head (e94bb9f) 24.47%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #191 +/- ## ========================================== + Coverage 24.36% 24.47% +0.10% ========================================== Files 17 17 Lines 2532 2521 -11 ========================================== Hits 617 617 + Misses 1915 1904 -11 ``` | [Impacted Files](https://app.codecov.io/gh/containerd/ttrpc-rust/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd) | Coverage Δ | | |---|---|---| | [src/common.rs](https://app.codecov.io/gh/containerd/ttrpc-rust/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL2NvbW1vbi5ycw==) | `35.57% <0.00%> (+0.99%)` | :arrow_up: | | [src/sync/client.rs](https://app.codecov.io/gh/containerd/ttrpc-rust/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd#diff-c3JjL3N5bmMvY2xpZW50LnJz) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/containerd/ttrpc-rust/pull/191/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=containerd)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.