containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

The connection stream will be out of order while a packet received whose size exceeds 4Mb #198

Closed Tim-Zhang closed 1 year ago

Tim-Zhang commented 1 year ago

We use 4Mb as the size limit of our ttrpc message(packet) , but we didn't discard the whole packet and just continue to process the next packet https://github.com/containerd/ttrpc-rust/blob/8968bfad4d01f886135e806692c6ecbf7679b8c4/src/sync/channel.rs#L120-L127 , and then the stream of the connection will be out of order.

Affected versions:

Tim-Zhang commented 1 year ago

v0.5, v0.8 and master have already fixed. I think v0.6 and v0.7 have no users currently, if anyone needs it, don't hesitate to reopen it.