search

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)
Apache License 2.0
195 stars 45 forks source link

Handle OS Interruptions #217

Closed jsturtevant closed 8 months ago

jsturtevant commented 9 months ago

When running on MacOs we found a bug:

Dec 12 18:45:42 spin-oci-worker containerd[102]: time="2023-12-12T18:45:42.523982005Z" level=info msg="Shim successfully started, waiting for exit signal..."
Dec 12 18:45:42 spin-oci-worker containerd[102]: time="2023-12-12T18:45:42.533327005Z" level=error msg="listener accept got Os { code: 4, kind: Interrupted, message: "Interrupted system call" }"
Dec 12 18:45:42 spin-oci-worker containerd[102]: time="2023-12-12T18:45:42.535132005Z" level=info msg="ttrpc server listener stopped"

This will retry the connection. I don't have a Mac to test this on but wanted to open it up for feedback incase others are seeing the error

codecov[bot] commented 9 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6520f9e) 24.35% compared to head (693f4c5) 24.33%. Report is 4 commits behind head on master.

Files Patch % Lines
src/sync/server.rs 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #217 +/- ## ========================================== - Coverage 24.35% 24.33% -0.03% ========================================== Files 16 16 Lines 2652 2655 +3 ========================================== Hits 646 646 - Misses 2006 2009 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

devigned commented 8 months ago

I'm going to test this out on my OSX machine and report back.

devigned commented 8 months ago

It took rebuilding the tree of dependencies, but it seems to be working on my OSX arm64 machine.

jsturtevant commented 8 months ago

@devigned Thanks for testing it out!

jsturtevant commented 8 months ago

@Tim-Zhang @wllenyj can we merge this?