ttrpc golang stream request with no FLAG_NO_DATA set

containerd / ttrpc-rust

Rust implementation of ttrpc (GRPC for low-memory environments)

Apache License 2.0

195 stars 45 forks source link

ttrpc golang stream request with no FLAG_NO_DATA set #221

Open abel-von opened 6 months ago

abel-von commented 6 months ago

The empty request is determined by whether FLAG_NO_DATA is set after #208 , but golang ttrpc seems not set this flag even it is an empty request. https://github.com/containerd/ttrpc/blob/main/client.go#L495. Shall we make it compatible with the case that client is golang? or do we set the flag in golang ttrpc?

wllenyj commented 6 months ago

We should be compatible with https://github.com/containerd/ttrpc/pull/157. Or there is a good enough reason to add it in golang.