search

containernetworking / plugins

Some reference and example networking plugins, maintained by the CNI team.
Apache License 2.0
2.17k stars 778 forks source link

bridge: remove useless code #962

Closed arthur-zhang closed 10 months ago

arthur-zhang commented 10 months ago

gws.defaultRouteFound is always false. firstV4Addr it is declared but not used anywhere in the code.

arthur-zhang commented 10 months ago

help wanted, seems ci is broken.

maiqueb commented 10 months ago

help wanted, seems ci is broken.

The issue you're complaining about was fixed in https://github.com/containernetworking/plugins/pull/967

Please rebase latest main branch, it should be OK then.

s1061123 commented 10 months ago

/lgtm

s1061123 commented 10 months ago

@dcbw I understood that. That is right that gws is used in calcGateways(). Let me double check that in #980