search

containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

network: pod: Get default internetwork model from pod configuration #528

Closed jcvenegas closed 6 years ago

jcvenegas commented 6 years ago

This patch change the default internetwork model based in the pod configuration.

Fixes: #527

Signed-off-by: Jose Carlos Venegas Munoz jose.carlos.venegas.munoz@intel.com

jcvenegas commented 6 years ago

@sameo @sboeuf added changes you suggested.

I created a temporal PR in runtime repository that uses this changes to allow modify the model from the runtime. https://github.com/clearcontainers/runtime/pull/887/files

jcvenegas commented 6 years ago

@sboeuf @mcastelino @sameo @jodh-intel updated PR to provide the model using runtimeConf.InterNetworkModel

jcvenegas commented 6 years ago

Updated vendor in https://github.com/clearcontainers/runtime/pull/887

sboeuf commented 6 years ago

@jcvenegas looks better but I still have a few comments !

sboeuf commented 6 years ago

@jcvenegas any updates on this one ?

jcvenegas commented 6 years ago

@sboeuf I will update this PR today.

sboeuf commented 6 years ago

@jcvenegas cool thx

sboeuf commented 6 years ago

Thanks for addressing comments ! LGTM