containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

Kata Containers shim support #531

Closed sameo closed 6 years ago

sameo commented 6 years ago

The Kata Containers shim needs the following parameters:

As a consequence, the virtcontainers support for the Kata Containers shim needs:

sameo commented 6 years ago

@jodh-intel Good points. I added some comments, let me know if that's clearer now.

sboeuf commented 6 years ago

@sameo according to https://github.com/kata-containers/agent/pull/83, I think you can remove your first commit agent: Return guest process information when starting a new one. We need another PR for virtcontainers in order to generate some unique IDs for every processes.

sameo commented 6 years ago

@sboeuf @jodh-intel This is ready to review.

jodh-intel commented 6 years ago

CI is unhappy:

13:57:32 Run go test and generate coverage:
14:02:32 Build timed out (after 5 minutes). Marking the build as aborted.
14:02:32 Build was aborted
sameo commented 6 years ago

@jodh-intel

CI is unhappy

This should be fixed now.

sboeuf commented 6 years ago

LGTM