Closed egernst closed 6 years ago
@mcastelino -- take a look?
@sboeuf -- agreed this is non-marginally sub-optimal method (the discovery of the socket in the network endpoint case). AFAICT it can't be made that generic, however, as this isn't just a socket being passed to qemu. In govmm we are taking this device type and appending a net device onto the command line, including setting/passing ip, route, Mac, etc. @mcastelino -- you have further thoughts here?
Good points, Sebastien. Let me make some updates.
@sboeuf @mcastelino -- update to address our comments.
@egernst Thanks, I'll take a look !
Yes looks good to me too. I'd like to wait for @amshinde approval before we merge. @egernst the CI is not passing.
@sboeuf -- let me know if you have any more inputs on this patchset. Thanks.
@egernst nope, it's all good !
Changes for introducing vhost-user enabling to virtcontainers.
In future still need to add support for generic vhost-user-block devices and to test vhost-user SCSI end to end.