containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

vhostuser enabling #536

Closed egernst closed 6 years ago

egernst commented 6 years ago

Changes for introducing vhost-user enabling to virtcontainers.

In future still need to add support for generic vhost-user-block devices and to test vhost-user SCSI end to end.

egernst commented 6 years ago

@mcastelino -- take a look?

egernst commented 6 years ago

@sboeuf -- agreed this is non-marginally sub-optimal method (the discovery of the socket in the network endpoint case). AFAICT it can't be made that generic, however, as this isn't just a socket being passed to qemu. In govmm we are taking this device type and appending a net device onto the command line, including setting/passing ip, route, Mac, etc. @mcastelino -- you have further thoughts here?

egernst commented 6 years ago

Good points, Sebastien. Let me make some updates.

egernst commented 6 years ago

@sboeuf @mcastelino -- update to address our comments.

sboeuf commented 6 years ago

@egernst Thanks, I'll take a look !

sameo commented 6 years ago

LGTM

Approved with PullApprove Approved with PullApprove

sboeuf commented 6 years ago

Yes looks good to me too. I'd like to wait for @amshinde approval before we merge. @egernst the CI is not passing.

amshinde commented 6 years ago

lgtm

Approved with PullApprove Approved with PullApprove

egernst commented 6 years ago

@sboeuf -- let me know if you have any more inputs on this patchset. Thanks.

sboeuf commented 6 years ago

@egernst nope, it's all good !