containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

Kata agent and proxy fixes #549

Closed sameo closed 6 years ago

sameo commented 6 years ago

Now that we can test all kata containers components with virtcontainers, here is my first round of fixes:

jodh-intel commented 6 years ago

Ping @sboeuf.

sboeuf commented 6 years ago

@jodh-intel I am gonna review this PR today !

sameo commented 6 years ago

@sboeuf I understand your concerns and it took me half a day to make the decision to go and implement the kata_proxy ops, for the following reasons:

sboeuf commented 6 years ago

LGTM

Approved with PullApprove Approved with PullApprove

sboeuf commented 6 years ago

PR merged since the Ubuntu 17.04 failure was not related to this PR but to the incapacity to reach some Ubuntu 17.04 repos.