search

containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

pkg/oci: Clarify resource calculation comment #556

Closed grahamwhaley closed 6 years ago

grahamwhaley commented 6 years ago

We use a couple of relativley simple formulas to work out how much RAM and how many vCPUs to allocate to the VM based on the Resource request we are passed in. Improve the comment on these calculations to make it clear which way they round and if they impose a floor to the resulting value.

Fixes: #554

Signed-off-by: Graham Whaley graham.whaley@intel.com

grahamwhaley commented 6 years ago

Just fyi, even though this is a benign comment change, I wanted to build and test check it, but don't seem able to do that on my machine right now.

jodh-intel commented 6 years ago

+1 for good comments!

lgtm

Approved with PullApprove Approved with PullApprove

devimc commented 6 years ago

lgtm

devimc commented 6 years ago

thanks @grahamwhaley for improve the comments

jodh-intel commented 6 years ago

The CI builds all finished successfully and coveralls also ran successfully, so why it's complaining I'm not sure. Merging...