containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

shim: Carry the info about terminal #577

Closed sboeuf closed 6 years ago

sboeuf commented 6 years ago

Some shim implementation (like Kata) might need to know if a terminal has been setup or not. This patch relies on Interactive field from the Cmd structure that was never really used but already holding this information.

Signed-off-by: Sebastien Boeuf sebastien.boeuf@intel.com

jodh-intel commented 6 years ago

lgtm

Approved with PullApprove Approved with PullApprove

sameo commented 6 years ago

LGTM

Approved with PullApprove Approved with PullApprove