search

containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

agent: send full data to agent #581

Closed devimc closed 6 years ago

devimc commented 6 years ago

don't use pointers to structures in the data that is sent to the agent

Depends-on: github.com/clearcontainers/proxy#208

fixes #580

Signed-off-by: Julio Montes julio.montes@intel.com

devimc commented 6 years ago

/cc @jodh-intel @sboeuf

amshinde commented 6 years ago

@devimc the pointers should be marshalled to json fields correctly. Can you describe what issue you are seeing?

devimc commented 6 years ago

@amshinde done, I described it in the issue

devimc commented 6 years ago

just vendoring virtcontainer in the proxy won't fix the issue, I tested it

amshinde commented 6 years ago

@devimc Vendoring should solve the issue unless I am missing something, else we would have seen this issue for all other fields.

jodh-intel commented 6 years ago

It would be good if we could have a test to ensure the behaviour is as we want, but...

lgtm

Approved with PullApprove Approved with PullApprove

devimc commented 6 years ago

@jodh-intel the test is in kubernetes, see https://github.com/clearcontainers/proxy/pull/196

sameo commented 6 years ago

@devimc Let's wait and see if @amshinde proxy vendoring fixes that issue.

devimc commented 6 years ago

clearcontainers/proxy#196 was merged and seems like this pr is not needed