containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

virtcontainers: Global re-organisation of the proxy/shim code #583

Closed sboeuf closed 6 years ago

sboeuf commented 6 years ago

This PR mainly reworks the proxy interface of virtcontainers, pushes shim and proxy down the stack, that is hidden behind the agent.

Fixes #518

sboeuf commented 6 years ago

cc @sameo @jodh-intel

sboeuf commented 6 years ago

@egernst yes that's the plan !

sboeuf commented 6 years ago

@jodh-intel @sameo PR is ready, tested and CI is passing, please review it. I am gonna re-upload an updated version for the commit message later.

jodh-intel commented 6 years ago

@sboeuf - Wowzers - a biggie. I'll take a look at this tomorrow morning as didn't get round to this today I'm afraid.

jodh-intel commented 6 years ago

@sboeuf - I like it! A simpler proxy interface and a simpler agent interface :)

lgtm

Approved with PullApprove Approved with PullApprove

sameo commented 6 years ago

LGTM

Approved with PullApprove Approved with PullApprove