search

containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

Add support for scsi for hotplugging block devices #584

Closed amshinde closed 6 years ago

amshinde commented 6 years ago

With this PR, block devices are hotplugged using either virtio-scsi or virtio-block based on a configuration.

amshinde commented 6 years ago

@sboeuf Can you take a look at this as well. CI is failing, likely due to lack of SCSI support on the agent side that needs to be merged first.

sboeuf commented 6 years ago

@amshinde yes I'll review both PR (virtcontainers and agent) tomorrow !

sboeuf commented 6 years ago

LGTM

amshinde commented 6 years ago

@jodh-intel Can you take another look at this?

sboeuf commented 6 years ago

@amshinde please update the agent commit sha1 in the runtime, this way, after you get your PR on the runtime merged, this PR should be re-triggered and pass.

jodh-intel commented 6 years ago

lgtm

Approved with PullApprove Approved with PullApprove

amshinde commented 6 years ago

@sboeuf I reran the CI after agent SHA update. The CI has passed now. Can we merge this? This does introduce SCSI as the default storage driver, which means we need to add support for SCSI for kata agent as well. We can change this to virtio-block in a follow up PR in the interim for kata.

sboeuf commented 6 years ago

@amshinde yes perfect !