containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

qemu: Log default kernel params #586

Closed jodh-intel closed 6 years ago

jodh-intel commented 6 years ago

Add a debug-only log call that logs the default kernel parameters. This is useful for users to identify which parameters are being set by virtcontainers, which are set by the runtime and which are user-specified.

A new defaultKernelParams() function was added to return these default parameters. This allow the default kernel parameters to be logged once prior to hypervisor startup and before they are combined with the defaults passed by the runtime.

Fixes #585.

Signed-off-by: James O. D. Hunt james.o.hunt@intel.com

devimc commented 6 years ago

lgtm

devimc commented 6 years ago

BenchmarkCreateStartStopDeletePodQemuHypervisorHyperstartAgentNetworkCNI failed o_O ?

jodh-intel commented 6 years ago

Weird.

/me kicks the CI again...

sameo commented 6 years ago

LGTM

Approved with PullApprove Approved with PullApprove