kata-agent: add network gRPC support

containers / virtcontainers

A Go package for building hardware virtualized container runtimes

Apache License 2.0

139 stars 43 forks source link

kata-agent: add network gRPC support #595

Closed egernst closed 6 years ago

egernst commented 6 years ago

Introduce support for setting up interface and routes when working with Kata agent.

Signed-off-by: Eric Ernst eric.ernst@intel.com

egernst commented 6 years ago

Functioning network gRPC calls dependent on https://github.com/kata-containers/agent/pull/126

egernst commented 6 years ago

This is dependent on the gRPC changes landing in kata-containers/agent and being re-vendorded.

egernst commented 6 years ago

Tested with latest agent and this PR now includes revendoring for latest gRPC changes. @sboeuf @jodh-intel can you take a look? Would be good to get working networking in...

sboeuf commented 6 years ago

@egernst I'll review it today !

jodh-intel commented 6 years ago

Yep - would be great to get networking in, once we have tests for it.

egernst commented 6 years ago

@jodh-intel I ended up doing some refactoring to help make it a bit more testable and then added some basic unit tests. This has also been verified with latest agent. The final looping over the resulting routes (and perhaps interfaces) will likely not be necessary in the future once we move to updating all the routes in a single shot.

PTAL, and thanks for the feedback.

egernst commented 6 years ago

@sboeuf -- updated.

egernst commented 6 years ago

see https://github.com/kata-containers/agent/pull/148

egernst commented 6 years ago

waiting for kata-containers/agent#148 to land so I can update the revendoring.

In the meantime, addressed feedback from @sameo and @jodh-intel and @sboeuf .

egernst commented 6 years ago

@sboeuf PTAL?

egernst commented 6 years ago

@jodh-intel @sboeuf - updated based on updated pod structure. PTAL