containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

Add support for dockershim pod annotations #607

Closed miaoyq closed 6 years ago

miaoyq commented 6 years ago

Dockershim use container labels to identify whether a docker container is a sandbox or a regular container. I have sent a PR https://github.com/moby/moby/pull/36181 in moby project to pass the label to the annotations of OCI runtime spec.

This commit add support for dockershim pod annotations.

/cc @sameo

Signed-off-by: Yanqiang Miao miao.yanqiang@zte.com.cn

sameo commented 6 years ago

@miaoyq Mostly looks good to me, except for the missing comments on the exported data.

miaoyq commented 6 years ago

@sameo Thanks, will add the comments. :-)

sameo commented 6 years ago

LGTM

Approved with PullApprove Approved with PullApprove