containers / virtcontainers

A Go package for building hardware virtualized container runtimes
Apache License 2.0
139 stars 43 forks source link

ARM: Couldn't find "flags" #608

Closed devimc closed 6 years ago

devimc commented 6 years ago

docker: Error response from daemon: OCI runtime create failed: Couldn't find "flags" from "/proc/cpuinfo" output: unknown.

grahamwhaley commented 6 years ago

Hmm, for parsing the CPU info to find if a device has the features we need ... - I saw this yesterday, but sadly I suspect this only handles things like vector math extensions, and not VM type stuff. https://opensource.googleblog.com/2018/02/cpu-features-library.html

devimc commented 6 years ago

@grahamwhaley yes, I did't see anything related to virtualization, I think we need to skip that validation in arm

sameo commented 6 years ago

@devimc What does /proc/cpuinfo look like on this machine?

devimc commented 6 years ago

@sameo

processor   : 0
BogoMIPS    : 200.00
Features    : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x43
CPU architecture: 8
CPU variant : 0x1
CPU part    : 0x0a1
CPU revision    : 1

processor   : 1
BogoMIPS    : 200.00
Features    : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x43
CPU architecture: 8
CPU variant : 0x1
CPU part    : 0x0a1
CPU revision    : 1

processor   : 2
BogoMIPS    : 200.00
Features    : fp asimd evtstrm aes pmull sha1 sha2 crc32
CPU implementer : 0x43
CPU architecture: 8
CPU variant : 0x1
CPU part    : 0x0a1
CPU revision    : 1
sboeuf commented 6 years ago

What are we supposed to check on x86 with flags ?

sameo commented 6 years ago

@sboeuf nesting

@devimc We should simply return false, nil if flags are not there.

sboeuf commented 6 years ago

Ok then we should throw a warning log. This way, a user on ARM with nesting being not supported, would be able to understand quiclky why it does not work.

sameo commented 6 years ago

Yes, a warning should be fine.