containous / traefik-extra-service-fabric

Traefik extra: Service Fabric Provider
Apache License 2.0
12 stars 14 forks source link

Grouped backend labels are incorrect #35

Closed jjcollinge closed 6 years ago

jjcollinge commented 6 years ago

The docs use the labels:

However in servicefabric_labelfuncs.go on line 11 and 12:

traefikSFGroupName                   = "traefik.servicefabric.groupname"
traefikSFGroupWeight                 = "traefik.servicefabric.groupweight"

This means the grouped labels do not match and canary testing is not possible with the documented labels.

NOTE: For anybody wishing to use this feature before a fix is merged, please use the labels:

I will post a fix shortly. cc: @lawrencegripper