containous / traefik-extra-service-fabric

Traefik extra: Service Fabric Provider
Apache License 2.0
12 stars 14 forks source link

bug: traefik.expose label doesn't use boolean value #4

Closed jjcollinge closed 6 years ago

jjcollinge commented 6 years ago

Currently the provider only checks for the existence of the label traefik.expose but doesn't check it's associated value. This means using <Label Key="traefik.expose">false</Label> will still actually expose the service. Offending line: servicefabric_tmpl.go:94