Fix backend name for Stateful services

containous / traefik-extra-service-fabric

Traefik extra: Service Fabric Provider

Apache License 2.0

12 stars 14 forks source link

Fix backend name for Stateful services #6

Closed ldez closed 6 years ago

ldez commented 6 years ago

Fix backend name for Stateful services: The name of the backend is {{$backendName := (print $service.Name $partition.PartitionInformation.ID)}} but the backend name in frontends is backendName = {{$service.Name}}/{{$partitionId}} (note the /)

Also:

update Træfik version.
Use new methods from Træfik for labels.
remove unused methods
rename functions in the template

lawrencegripper commented 6 years ago

Thanks, will try and take a look asap - most likely Friday, sorry for the delay

lawrencegripper commented 6 years ago

@petertiedemann Wanted to flag that this change will require you to refactor the template we setup as the function names exposed have been renamed. Included you here so you can see the renames required. Let me know if you have any issues with the changes.

ldez commented 6 years ago

I have done really bad things:

too many things in this PR
mix a fix for 1.5 and a refactor related to master

I will revert and redo this PR (in 2 PRs this time) Sorry for this.