search

containous / traefik-extra-service-fabric

Traefik extra: Service Fabric Provider
Apache License 2.0
12 stars 14 forks source link

Add SameSite, HTTPOnly, Secure cookie support (v1.7) #60

Closed tpayne84 closed 3 years ago

tpayne84 commented 3 years ago
  1. Update traefik dependency to latest v1.7 changes.
  2. Update servicefabric provider template to include the [SameSite, HTTPOnly, Secure] labels under LoadBalancer.Stickiness.

Related to https://github.com/traefik/traefik/pull/7667

tpayne84 commented 3 years ago

I see the build for this has failed, though I do not see how my changes are related. Perhaps they are and I am missing it, but this open issue looks to be related; context loading failed: no go files to analyze

Either way, any guidance on how best update this PR for approval is appreciated.

ldez commented 3 years ago

The update of this part is a bit complex, I will help you with this. I just have to find a bit of time to handle that.

tpayne84 commented 3 years ago

@ldez Great, I will review your suggestions once you have had an opportunity to generate a response (no rush).

Thanks!