search

contao / news-bundle

[READ-ONLY] Contao News Bundle
GNU Lesser General Public License v3.0
9 stars 14 forks source link

allow newsreader selection in newslist #39

Closed fritzmg closed 6 years ago

fritzmg commented 6 years ago

Imho there is no real reason [1] not to allow the selection of a newsreader also in the newslist - not just the newsarchive (or the eventlist for that matter).

This would allow the following URL structure:

example.org/news            // the news list page
example.org/news/news-entry // news detail page

without having to resort to other means, like using the newslist_extended extension or the old urlcleaner extension, or including either the newslist or newsreader module in your own template, depending on whether there is an auto_item parameter present.

[1] one "reason" not to do it would be because people get often confused about this feature. They sometimes mistakenly select an eventreader in their eventlist module for example, which they then display somewhere in the page layout, causing problems on the newsreader page

leofeyer commented 6 years ago

IMHO there is also no real reason to change the current behaviour. Just use a news archive instead to accomplish what you have outlined above. 😉

fritzmg commented 6 years ago

The news archive module behaves differently though. It does not make use of the newsListFetchItems hook for instance.

michb commented 6 years ago

Sorry did not look into pull request.

I think it would improve consistency between calendar-bundle and news-bundle, in my opinion the two most used bundles. Also like @fritzmg said archive and listing module behaves differently, with archive module you cannot limit the amount or use the featured-flag.

Also these changes do no harm, people who want to use it like now can ignore the new field in tl_module and all other can use this new feature.

leofeyer commented 6 years ago

Merged in contao/contao@936269cb6f54807caa1f89bab5011e73bac7ce93. Thank you @fritzmg.