Missing language support - i18n

conterra / mapapps-what3words

This bundle integrates what3words into map.apps.

Apache License 2.0

0 stars 1 forks source link

Missing language support - i18n #1

Closed transkamp closed 8 months ago

transkamp commented 2 years ago

If a user starts with the english locale support (https://demos.conterra.de/mapapps/resources/apps/downloads_what3words/index.html?lang=en) the user gets a german locale ui. i18n support ist missing for the intro bundle, and the toggle button.

julkuh commented 2 years ago

Hint: app.json is not translated and uses hard-coded string values. This is just a problem with this sample app, not with the waht3words bundle itself.

transkamp commented 2 years ago

I can't find any i18n resource keys in the bundle. in my opnion they are missing here https://github.com/conterra/mapapps-what3words/tree/main/src/main/js/bundles/dn_what3words

njakuschona commented 11 months ago

The commit 6213fe1 adds the i18n files. Thus the tooltip is now shown in the selected language. As @julkuh mentioned, the app.json is not translated since it only belongs to the sample app and not the bundle itself.

sholtkamp commented 8 months ago

Fixed by Nick now merged into main