contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts
https://py.contrails.org/
Apache License 2.0
59 stars 17 forks source link

Update notebook utilities and testing #133

Closed mlshapiro closed 10 months ago

mlshapiro commented 10 months ago

Closes #18

Looking at the Github Actions doctest run, it may impractical to actually run nb-test in the actions. Lets discuss at the next standup

Changes

Updates notebook plumbing to execute notebooks on validation in Doc / Notebook Tests and ensure outputs are cleaned up.

Note that if there is a cell that won't execute on a generic complete installation of pycontrails, you need to add the tags skip-execution and nbval-skip to that cell. The Cache notebook has an example of this.

You add tags with the Property Inspector (View -> Property Inspector).

Internals

TODO:

Tests

Reviewer

Select @zebengberg @trdean1

mlshapiro commented 10 months ago

TODO:

trdean1 commented 10 months ago
  • Ensure there are no Warnings.

This warning will come up in my notebook. Should we just remove this warning or maybe not raise it if fuel_flow is provided?

zebengberg commented 10 months ago
  • Ensure there are no Warnings.

This warning will come up in my notebook. Should we just remove this warning or maybe not raise it if fuel_flow is provided?

I think it's best to remove this warning. I think it's mostly a historical artifact.

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB