Closed mlshapiro closed 10 months ago
TODO:
nbval
with nbval-lax
metview
dependency - put info into notebook.
- Ensure there are no Warnings.
This warning will come up in my notebook. Should we just remove this warning or maybe not raise it if fuel_flow
is provided?
- Ensure there are no Warnings.
This warning will come up in my notebook. Should we just remove this warning or maybe not raise it if
fuel_flow
is provided?
I think it's best to remove this warning. I think it's mostly a historical artifact.
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
Closes #18
Changes
Updates notebook plumbing to execute notebooks on validation in Doc / Notebook Tests and ensure outputs are cleaned up.
Note that if there is a cell that won't execute on a generic complete installation of
pycontrails
, you need to add the tagsskip-execution
andnbval-skip
to that cell. TheCache
notebook has an example of this.You add tags with the Property Inspector (View -> Property Inspector).
Internals
make nb-test
). Continues to usenbval-lax
.make nb-execute
)make nb-clean
)TODO:
cfgrib
won't load in the doctest action because theeccodes
is not present. This is unfortunately complicated, so I ignored theGFS
notebook.run-cocip-on-flight
requires special meteorology. I ignored the file fromnb-test
since we haven't staged in this meteorology.specific-humidity-interpolation
requiresmetview
, which we don't install on the Action. Ignored for now.Tests
make test
)Reviewer