contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts
https://py.contrails.org/
Apache License 2.0
59 stars 17 forks source link

Timestep when calling the function plume_temporal_evolution in Cocipgrid #244

Closed zebengberg closed 1 month ago

zebengberg commented 1 month ago

Discussed in https://github.com/contrailcirrus/pycontrails/discussions/243

Originally posted by **Frank251826** September 27, 2024 The timestep here directly takes the parameter "dt_integration". For the first contrail, dt are usually not as long as dt_integration. I am wondering if this is something we can modify a little bit. Start at line 1674 to 1684 in cocip_grid: sigma_yy_t2, sigma_zz_t2, sigma_yz_t2 = contrail_properties.plume_temporal_evolution( width_t1=width_t1, depth_t1=depth_t1, sigma_yz_t1=sigma_yz_t1, dsn_dz_t1=dsn_dz_t1, diffuse_h_t1=diffuse_h_t1, diffuse_v_t1=diffuse_v_t1, seg_ratio=seg_ratio_t12, dt=params["dt_integration"], max_depth=params["max_depth"], ) Refer to the same usage in Cocip, dt is defined as contrail_2['time']-contrail_1['time'], which is reasonable. A lot appreciate if anyone could provide some help.
zebengberg commented 1 month ago

Closed in #245