Extend ACCF relative humidity

contrailcirrus / pycontrails

Python library for modeling contrails and other aviation climate impacts

https://py.contrails.org/

Apache License 2.0

59 stars 17 forks source link

Closed zebengberg closed 4 days ago

zebengberg commented 1 week ago

Allow the ACCF model to accept relative humidity as a percentage or as a proportion.
Include ecmwf.RelativeHumidity in ACCF.met_variables so that ERA5(..., variables=ACCF.met_variables) no longer raises an error.

@jsmretschnig let me know if this fixes the issue you identified in #264

review-notebook-app[bot] commented 1 week ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jsmretschnig commented 3 days ago

Seems like the ValueError is gone now, thanks! So the request is actually being sent to the CDS where it is processed.

Will test the whole workflow as soon as CDS is running properly again.

jsmretschnig commented 2 days ago

Seems to work! Found another bug though, will open a new issue/PR. Will reach out to you for best-practices in general.