search

contributte / invoice

:memo: PDF invoice generator
https://contributte.org/packages/contributte/invoice.html
MIT License
96 stars 25 forks source link

v3.0.0 fix - ITemplate constructor arguments #23

Closed peterkracik closed 3 years ago

peterkracik commented 3 years ago

Using a Formatter interface rather than class for the template constructor arguments

peterkracik commented 3 years ago

Hi, would it be possible to merge my change to the v3.0.0?

thanks

f3l1x commented 3 years ago

Please change PR to master branch.

f3l1x commented 3 years ago

ping @peterkracik

peterkracik commented 3 years ago

@f3l1x I did the modification on the current stable version (3.0.0), which is I believe the fix/ci. The file on master branch is already changed and also it contains the edit I requested (using IRenderer instead of Renderer)

f3l1x commented 3 years ago

Sorry, I don't get it, master branch is mandatory. fix/ci was left-over from PR (https://github.com/contributte/invoice/pull/18).

f3l1x commented 3 years ago

Constructor was removed from ITemplate (https://github.com/contributte/invoice/commit/0fcf6bb9e262f594c6ec72ce56a63a42077362ee).