search

contributte / rabbitmq

🐰 RabbitMQ (AMQP, STOMP, MQTT) using BunnyPHP for Nette Framework (@nette).
https://contributte.org/packages/contributte/rabbitmq.html
MIT License
24 stars 25 forks source link

Support for bulk consumer #45

Closed bckp closed 3 years ago

paveljanda commented 3 years ago

I would, after all appreciate leaving the old Consumer code as is without making any common base. I feel the code is not easy to read so it may be better to just use a whole new class for the new approach. WDYT?

Also, could you please provide a docs (you will find the docs here: https://github.com/contributte/rabbitmq/tree/master/.docs) section with comprehensive bulk consumer description? Thanks a lot

bckp commented 3 years ago

Well, we can and I do, it is not problem to keep Consumer intact, and add new functionality only to BulkConsumer and ConsumerFactory, but there will be duplicated code... That was main purpose of rewrite of Consumer, to keep logic only on one place.

//edit: cant be done, due design if we keep Consumer intact, we need to do BC breaks, so this is only way without BC breaks to support this

paveljanda commented 3 years ago

Thanks!!!