IConvergenceOptions.handshakeTimeout should be renamed.

convergencelabs / convergence-project

The project used for Convergence Project Management and Issue Reporting

https://convergence.io

42 stars 5 forks source link

IConvergenceOptions.handshakeTimeout should be renamed. #239

Closed mmacfadden closed 3 years ago

mmacfadden commented 3 years ago

Versions

Convergence Version: 1.0.0-rc.9

*Desired Feature The client no longer does a "handshake" per-se. IConvergenceOptions.handshakeTimeout could be better named IConvergenceOptions.connnectionRequestTimeout. the new options will look like this.

export interface IConvergenceOptions {

  connection?: {
    timeout?: number;
    connectionRequestTimeout?: number;
  };
  ...
}