Closed anoblet closed 1 year ago
Path | Size |
---|---|
packages/cxl-ui/pkg/dist-web/cxl-ui.js | 33.83 KB (+0.76% 🔺) |
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js | 11.87 KB (0%) |
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js | 25.17 KB (+1.07% 🔺) |
packages/cxl-ui/pkg/dist-web/vendor.js | 125.6 KB (0%) |
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js | 197.63 KB (+0.27% 🔺) |
I'm also thinking about naming convention here. We should have something universal. .ordered-list-heavy
came to my mind. WDYT @anoblet @lkraav
Making this responsive is harder than I thought.
I ditched the fluid typography effort. It should look good on mobile now.
I wasn't able to use ::marker
since it is a mandatory inline-block
element which doesn't allow for the use of background-color
.
LGTM
@lkraav any doubts about current solution?
I wasn't able to use
::marker
since it is a mandatoryinline-block
element which doesn't allow for the use ofbackground-color
.
I'm confused about what this means. I'm reading it as background-color
cannot be used with inline-block
elements, but testing it, seems to work fine? See middle item :arrow_down:
Source https://developer.mozilla.org/en-US/docs/Web/CSS/background-color
I meant to say inline-text
element. I wasn't able to add a background color, and came across this SO question: https://stackoverflow.com/questions/68135553/how-to-add-a-css-background-for-marker-in-list
MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/::marker#allowable_properties
JSFiddle: https://jsfiddle.net/hbsvnzo6/22/
MDN: https://developer.mozilla.org/en-US/docs/Web/CSS/::marker#allowable_properties
It's clear background*
properties are not allowed for ::marker
and I consider current solution as good enough to merge.
LGTM
any doubts about current solution?
It creates a horizontal scrollbar on 320px width screen.
It creates a horizontal scrollbar on 320px width screen.
Let's fix it @anoblet
Updated
Clickup: https://app.clickup.com/t/861mnfcj4
Screenshot: