Closed kertuilves closed 1 year ago
This is looking good.
Quick clarification. They only show when they have non-zero values? or?
I would change the label from CXL explored to Complete library
This is looking good.
Quick clarification. They only show when they have non-zero values? or?
I would change the label from CXL explored to Complete library
@heshfekry The stats count is meant to change the count of items there is in the row. For now there is data for 4 items (max amount in the design) and the count is there to just show what would happen if there is less than 4 items.
Ok great.
On Thu, Jul 6, 2023 at 1:21 PM kertuilves @.***> wrote:
This is looking good.
Quick clarification. They only show when they have non-zero values? or?
I would change the label from CXL explored to Complete library
@heshfekry https://github.com/heshfekry The stats count is meant to change the count of items there is in the row. For now there is data for 4 items (max amount in the design) and the count is there to just show what would happen if there is less than 4 items.
— Reply to this email directly, view it on GitHub https://github.com/conversionxl/aybolit/pull/291#issuecomment-1623498486, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARMYIUDXC7L5CCOCXDDGEBTXO2NQLANCNFSM6AAAAAA2AD7KI4 . You are receiving this because you were mentioned.Message ID: @.***>
--
Hesh Fekry President at CXL Schedule a user interview http://email.cxl.com/e/c/eyJlbWFpbF9pZCI6IlJPSGpCQUFBQVg5NVI2dUNrMllXbTN1dUhHMXhCdz09IiwiaHJlZiI6Imh0dHBzOi8vY2FsZW5kbHkuY29tL2QvY3JwLWI0cC01dHgvdXNlci1pbnRlcnZpZXc_dXRtX2NhbXBhaWduPXByb2R1Y3QtcGxheWJvb2stY29tbXVuaXR5LW9uYm9hcmRpbmdcdTAwMjZ1dG1fY29udGVudD1GZWVkYmFjaytSb3VuZCt1cFx1MDAyNnV0bV9tZWRpdW09ZW1haWxfYWN0aW9uXHUwMDI2dXRtX3NvdXJjZT1jdXN0b21lci5pbyIsImludGVybmFsIjoiZTFlMzA0MGE4MjAzZTRhYTEyIiwibGlua19pZCI6NzgxNH0/dd39eec5fb775f55aabdddeb2b51944f899d9f1c26ec9221bba8ce5c454c46cb http://email.cxl.com/e/c/eyJlbWFpbF9pZCI6IlJPSGpCQUFBQVg5NVI2dUNrMllXbTN1dUhHMXhCdz09IiwiaHJlZiI6Imh0dHBzOi8vY2FsZW5kbHkuY29tL2N4bC1wcm9kdWN0L3BsYXlib29rLXByaXZhdGUtYmV0YT9tb250aD0yMDIxLTA1XHUwMDI2dXRtX2NhbXBhaWduPXByb2R1Y3QtcGxheWJvb2stY29tbXVuaXR5LW9uYm9hcmRpbmdcdTAwMjZ1dG1fY29udGVudD1GZWVkYmFjaytSb3VuZCt1cFx1MDAyNnV0bV9tZWRpdW09ZW1haWxfYWN0aW9uXHUwMDI2dXRtX3NvdXJjZT1jdXN0b21lci5pbyIsImludGVybmFsIjoiZTFlMzA0MGE4MjAzZTRhYTEyIiwibGlua19pZCI6NzA1NH0/b958a0076937d567fee7c4abe7a2f3c28e1852706a6f4206e1b29c676d892af3
Our address: 901 S Mo Pac Expy, Suite 150, Barton Oaks Plaza One, Austin TX 78746
Component has max value of 4 items in row which is sufficient for current design. I'm just wondering if it's worth making this component more universal and increase the limit.
@heshfekry what do you think? @kertuilves what's your estimation on providing such functionality:
- for max 8 items,
- for any amount of items?
Dont see the need just yet. If its less than 2hrs of work sure.
Otherwise can just duplicate conponent of max 4 to create different stat bundles of max 4 per block.
Component has max value of 4 items in row which is sufficient for current design. I'm just wondering if it's worth making this component more universal and increase the limit. @heshfekry what do you think? @kertuilves what's your estimation on providing such functionality:
- for max 8 items,
- for any amount of items?
Dont see the need just yet. If its less than 2hrs of work sure.
Otherwise can just duplicate conponent of max 4 to create different stat bundles of max 4 per block.
I made the changes so when the count is updated and it's bigger than 4, then it just adds last item again and again.
https://app.clickup.com/t/861n0qjxj