conversionxl / aybolit

Lightweight web components library built with LitElement.
https://conversionxl.github.io/aybolit/
MIT License
7 stars 8 forks source link

Dashboard 2.0 #305

Closed pawelkmpt closed 1 year ago

pawelkmpt commented 1 year ago
github-actions[bot] commented 1 year ago

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 61.63 KB (+69.87% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (-0.06% 🔽)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 26.96 KB (+5.99% 🔺)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (+1.3% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 237.19 KB (+13.72% 🔺)
pawelkmpt commented 1 year ago

@kertuilves after rebasing feat/dashboard on top of master and resolving yarn.lock conflicts I see few issues with dashboard. Components. Look at the screenshots and comments below.

pawelkmpt commented 1 year ago

cxl-course-dialog

As far as I remember dialog was not full width before. Do you confirm? If so, please fix it.

Screenshot 2023-08-16 at 12 18 45 Screenshot 2023-08-16 at 12 18 59

pawelkmpt commented 1 year ago

cxl-dashboard-header

cxl-dashboard-notification

Different widths (margins/paddings ?) depending on the story.

Screenshot 2023-08-16 at 12 19 21 Screenshot 2023-08-16 at 12 19 36 Screenshot 2023-08-16 at 12 19 47