search

convexengineering / gpkit

Geometric programming for engineers
http://gpkit.readthedocs.org
MIT License
206 stars 40 forks source link

spring cleaning #1404

Closed bqpd closed 5 years ago

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

whoburg commented 5 years ago

Let me know when ready for review!

bqpd commented 5 years ago

@whoburg I think this one will be fine without review (it's just me re-reading the code and removing old stuff) but does that mean you're interested in getting back into reviewing code? :) Send me an email!

whoburg commented 5 years ago

Yep would love to review code when useful. Including this one -- looks like great improvements... on a super quick scan I definitely want to discuss changing NEAR_DUAL_FEAS to OPTIMAL though.

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

@whoburg, you're welcome to review this if you'd like! Should be an...interesting wander through the codebase. re: the MOSEK NEAR_DUAL_FEAS, our tolerance for good solutions is a bit lower than theirs and has been for a bit; this PR just moves that check from gp.py to the mosek solver code, thus closing an old #TODO.

whoburg commented 5 years ago

Great! Will review this weekend.

bqpd commented 5 years ago

test models please

whoburg commented 5 years ago

@bqpd I'll be in and out of responsiveness this week but will check in periodically and will definitely reply to any convos eventually

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test models please

bqpd commented 5 years ago

test this please

bqpd commented 5 years ago

@whoburg thanks for your review!