coollabsio / coolify

An open-source & self-hostable Heroku / Netlify / Vercel alternative.
https://coolify.io
Apache License 2.0
32.07k stars 1.66k forks source link

[Bug]: Redeploying / Stopping no longer wait for the container to stop gracefully #3593

Open Vahor opened 2 days ago

Vahor commented 2 days ago

Error Message and Logs

No error, the deploy logs run sudo docker rm -f [appName] without running stop before.

If I try locally with an old version like v4.0.0-beta.341 it works and I can see a docker stop --time=30 tcsg08sssog8ko48s80gso8s-170315609712

With the latest version 343 this line is no longer here.

Steps to Reproduce

  1. Use any app image, like nginx:latest
  2. Start the app, wait for it to be running
  3. Click on redeploy (or restart)
  4. The container was removed using rm and no sign of stop

Example Repository URL

No response

Coolify Version

v4.0.0-beta.343

Are you using Coolify Cloud?

No (self-hosted)

Operating System and Version (self-hosted)

Ubuntu 24.04.1 LTS

Additional Information

In my case I've upgraded because the new version should have updated the stop timeout from 30s to 300s (I'd hope for more / configurable but 300s is great).

But now the app is directly removed without any wait time 😭