Update "Meet the team" page to include 2023 subcom

coopsoc / website

https://coopsoc.com.au

7 stars 5 forks source link

Update "Meet the team" page to include 2023 subcom #20

Closed scorpiontornado closed 10 months ago

scorpiontornado commented 1 year ago

[x] Add 2023 subcom
[x] Add 2023 first year reps + pics
[x] Make title, url, header link, and page header consistent (currently "Our Team | UNSW Co-op Society", "https://coopsoc.com.au/team", "The Team", and "MEET THE TEAM", respectively
[x] Address team.jsx line 40: 'TODO: have this be a subpage of "About"'
[x] #24
[x] Vertically centre left-hand column of subcom section of /team in each row/portfolio (probably involves centring Subcom.jsx <div className="col-sm-8"> within the parent "row" div)

scorpiontornado commented 1 year ago

Also, get pictures for 2023 first year representatives

theawesomew commented 1 year ago

If anyone would like to make a pull request for this issue - please feel free. It can be addressed pretty quickly if you'd like to.

scorpiontornado commented 1 year ago

Might do it tmr, do you know where pics for the 1st year reps come from? Do I just dm them? @theawesomew

scorpiontornado commented 1 year ago

Making naming consistent depending on space available - "team", "the team", and "meet the team" (removing "our team").

theawesomew commented 1 year ago

Aks specifically asked me to remove sub-pages because it makes the UI more cluttered and less accessible (you have to search through the user interface for things rather than them being immediately obvious). So, we'll stick to the 'no sub menus' gig because we're never going to have so many pages that we can't just do that :)

scorpiontornado commented 1 year ago

@theawesomew how's the vertical centring of the subcom portfolio names/icons going?

scorpiontornado commented 10 months ago

Would probably be easy once we're using Reactstrap properly

scorpiontornado commented 10 months ago

Was really easy to centre them actually, just had to move d-flex align-items-center from the subcom list col to the parent row (https://stackoverflow.com/a/42252877)