coopsoc / website

https://coopsoc.com.au
7 stars 5 forks source link

Add first year facebook group link to navbar #59

Closed scorpiontornado closed 10 months ago

scorpiontornado commented 10 months ago

Added first year facebook group link to navbar, refactored navbar to use .map (simplifying how links are added), and added redirect rules to the next config (/first/calendar was sending you to 404 in the dev environment without it).

Update on redirects: turns out we're using cloudflare for the calendar redirect, which is why it wasn't working in the dev environment. We should probably pick either cloudflare or next. I'd say next is easier for us if we (the devs) wanted to add stuff like the first year facebook group to the navbar (while having a professional, easy-to-remember link to share). However, having redirects in cloudflare makes it easier for non-tech people to add redirects (that won't necessarily need to appear visually on the website), like the exec/subcom calendars.

Hovering over the first year group link: image

Resolves #55

scorpiontornado commented 10 months ago

image Turns out when a link is clicked, it becomes slightly too big to fit on one line. Ideal solution would be to stretch out the navbar more, there's a lot of padding on the left and right.

scorpiontornado commented 10 months ago

It's definitely a group, "UNSW Co-op 2024 (First Years)"

scorpiontornado commented 10 months ago

Not too sure how to fix the padding issue cause it seems to be the default container width, I'd have to override it or make the padding work with container-fluid (which extends to the end)

scorpiontornado commented 10 months ago

Other option would be shorten the name, but "1st Yr FB Group" isn't short enough, maybe "First Year FB" or similar could work?

scorpiontornado commented 10 months ago
image

That works. Also, what are we going to do about the /calendar redirect - cloudflare or nextjs?