Please consider fixing issues detected by repository checker

[ioBroker-Bot]

Notification from ioBroker Check and Service Bot

Dear adapter developer,

I'm the ioBroker Check and Service Bot. I'm an automated tool processing routine tasks for the ioBroker infrastructure. I have recently checked the repository for your adapter roborock for common errors and appropiate suggestions to keep this adapter up to date.

This check is based the current head revisions (master / main branch) of the adapter repository

Please see the result of the check below.

ioBroker.roborock

-

ERRORS:

• [ ] :heavy_exclamation_mark: [E507] missing size attributes [xs,sm,md,lg,xl] for checkbox at admin/jsonConfig.json/items/enable_map_creation
• [ ] :heavy_exclamation_mark: [E507] missing size attributes [xs,sm,md,lg,xl] for number at admin/jsonConfig.json/items/map_creation_interval
• [ ] :heavy_exclamation_mark: [E507] missing size attributes [xs,sm,md,lg,xl] for number at admin/jsonConfig.json/items/updateInterval
• [ ] :heavy_exclamation_mark: [E507] missing size attributes [xs,sm,md,lg,xl] for password at admin/jsonConfig.json/items/password
• [ ] :heavy_exclamation_mark: [E507] missing size attributes [xs,sm,md,lg,xl] for text at admin/jsonConfig.json/items/username
• [ ] :heavy_exclamation_mark: [E510] responsive check: maximum issues reached, please fix reported ones and recheck

WARNINGS:

• [X] :eyes: [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json
• [ ] :eyes: [W172] "common.localLink" in io-package.json is deprecated. Please define object "common.localLinks": { "_default": "..." }

:thumbsup: No suggestions found

Please review issues reported and consider fixing them as soon as appropiate.

Errors reported by repository checker should be fixed as soon as possible. Some of them require a new release to be considered as fixed. Please note that errors reported by checker might be considered as blocking point for future updates at stable repository.

Warnings reported by repository checker should be reviewed. While some warnings can be ignored due to good reasons or a dedicated decision of the developer, most warnings should be fixed as soon as appropiate.

You may start a new check or force the creation of a new issue at any time by adding the following comment to this issue:

@iobroker-bot recheck or @iobroker-bot recreate

Please note that I (and the server at GitHub) have always plenty of work to do. So it may last up to 30 minutes until you see a reaction. I will drop a comment here as soon as I start processing.

Feel free to contact me (@iobroker-bot) if you have any questions or feel that an issue is incorrectly flagged.

And THANKS A LOT for maintaining this adapter from me and all users. Let's work together for the best user experience.

your ioBroker Check and Service Bot

@mcm1957 for evidence

Last update at Fri, 29 Nov 2024 05:32:31 GMT based on commit 2fe5bd1f375d1d36b560971f5922fa5730043245 ioBroker.repochecker 3.2.2

[copystring]

Fixed via https://github.com/copystring/ioBroker.roborock/commit/80086a34d54f35b5318fcc15cc6fe40353fe5726

[ioBroker-Bot]

This issue has been updated by ioBroker Check and Service Bot

The following issues are not fixed and have been reopened [W172] "common.localLink" in io-package.json is deprecated. Please define object "common.localLinks": { "_default": "..." }

The following issues are new and have been added [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json

[ioBroker-Bot]

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json

:thumbsup:Thanks for fixing the issues.

The following issues are new and have been added [E507] missing size attributes [xs,sm,md,lg,xl] for checkbox at admin/jsonConfig.json/items/enable_map_creation [E507] missing size attributes [xs,sm,md,lg,xl] for number at admin/jsonConfig.json/items/map_creation_interval [E507] missing size attributes [xs,sm,md,lg,xl] for number at admin/jsonConfig.json/items/updateInterval [E507] missing size attributes [xs,sm,md,lg,xl] for password at admin/jsonConfig.json/items/password [E507] missing size attributes [xs,sm,md,lg,xl] for text at admin/jsonConfig.json/items/username [E510] responsive check: maximum issues reached, please fix reported ones and recheck

[copystring]

This issue has been updated by ioBroker Check and Service Bot

The following issues have been fixed [W034] @iobroker/adapter-core 3.1.6 specified. 3.2.2 is recommended. Please consider updating dependencies at package.json

👍Thanks for fixing the issues.

The following issues are new and have been added [E507] missing size attributes [xs,sm,md,lg,xl] for checkbox at admin/jsonConfig.json/items/enable_map_creation [E507] missing size attributes [xs,sm,md,lg,xl] for number at admin/jsonConfig.json/items/map_creation_interval [E507] missing size attributes [xs,sm,md,lg,xl] for number at admin/jsonConfig.json/items/updateInterval [E507] missing size attributes [xs,sm,md,lg,xl] for password at admin/jsonConfig.json/items/password [E507] missing size attributes [xs,sm,md,lg,xl] for text at admin/jsonConfig.json/items/username [E510] responsive check: maximum issues reached, please fix reported ones and recheck

Honestly, this is not a good requirement. My config with a fixed with set like so: "style": { "width": "198px" } works much better. xs,sm, etc. feels buggy and weird. For example, I set "lg": 1, and test the switch to "md": 3, by reducing the width of the window with the config open, switches way too late to md. So the item is truncated until it switches to md and "ld": 2, or larger is way too wide for my liking. So I'm not implementing this.

[copystring]

See https://github.com/copystring/ioBroker.roborock/issues/679