coralproject / ask

A better way for journalists to manage forms, submissions, and galleries. Because journalism needs everyone.
https://coralproject.net/products/ask.html
Other
42 stars 8 forks source link

Clicking anywhere in the gray background bar (not just the form name) on the Forms page should open a form #83

Closed kgardnr closed 8 years ago

kgardnr commented 8 years ago

Otherwise, you can't open forms with no Form Name.

blank_form
pablocubico commented 8 years ago

Looks like there is no direct way on react-mdl to add a listener to a row, which should be a very simple thing to do. I could write a workaround, maybe using some DOM traversing on a cell event, or something like that, but maybe we should discuss if react-mdl is the library to use before it's too late. I already had to send a few patches and had to rollback a commit because of things not working on react-mdl, it also lacks customization features.

For example: this is the table component of the material-ui lib.

http://www.material-ui.com/#/components/table

The API looks more coherent, but I don't know the lib in depth, I think Riley had a few concerns about material-ui.

Any thoughts? Other libs?

pablocubico commented 8 years ago

Putting the "blocked" label just to mark it as "on hold"...

okbel commented 8 years ago

I agree. I don't think react-md is mature enough to fit our needs. Also I ran into some issues too (https://github.com/tleunen/react-mdl/issues/386). I'm looking into material ui in depth to see if its a good option for us.

kgardnr commented 8 years ago

I'm gonna close this for now; we're addressing it more simply here: https://github.com/coralproject/ask/issues/110