search

corazawaf / coraza-caddy

OWASP Coraza middleware for Caddy. It provides Web Application Firewall capabilities
https://www.coraza.io/
Apache License 2.0
357 stars 41 forks source link

chore: Update README #164

Closed fardin01 closed 3 months ago

fardin01 commented 4 months ago

This commit updates the README to include the findings in https://github.com/corazawaf/coraza-caddy/issues/137, because it is useful to have this information directly in the README rather than having to search for it.

fardin01 commented 3 months ago

LGTM. The next obvious step will be (in a followup PR) to add this example as part of the github action build process, so we can test everything works properly 😄

Great.

Do you mean adding it to e2e tests?

fzipi commented 3 months ago

🤔 It was more about checking that the example files are sane and won't break anything if used.
I was thinking on a simple GHA that starts a caddy server with the example files and we test the response using curl or similar to see if it contains the host, etc. But if that is about e2e, then could be.

M4tteoP commented 3 months ago

Note: tests are failing because of https://github.com/corazawaf/coraza-caddy/pull/165, this branch needs to be rebased once that PR is merged

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud