search

coreruleset / documentation

CRS Documentation
https://coreruleset.org/docs/
3 stars 20 forks source link

Issue #94: Adds 'HAProxy Technologies' as a commercial WAF appliance vendor #96

Closed NickMRamirez closed 1 year ago

dune73 commented 1 year ago

Hey @NickMRamirez, thank you for the PR, happy to list HAProxy together with the other alternatives.

I'm not entirely happy with the wording, though. It reads too much like marketing blurb. I realize that the description of Kemp / Progress includes the word "popular", but I think this is as far as it should go. If your product is the fastest LB, then good for you, but CRS can not make that judgement and given this is our documentation it would appear as if we would make this judgement. I'm also not sure our audience needs to learn about HAProxy Technologies as the company behind HAProxy. I guess you get my idea here.

And sorry for being so blunt, but @RedXanadu who is working on the documentation a lot in his spare time is a Loadbalancer.org employee and I really like how he is not pushing his agenda into the documentation.

NickMRamirez commented 1 year ago

Not a problem. I put our boilerplate marketing text in, but it makes sense now why that wouldn't be appropriate. How does this updated text look?

### HAProxy Technologies

HAProxy Technologies embeds ModSecurity v3 in three of its products via the Libmodsecurity module. 
ModSecurity is included with: HAProxy Enterprise, HAProxy ALOHA, and HAProxy Enterprise Kubernetes
Ingress Controller. 

To learn more, visit the [HAProxy WAF solution page on haproxy.com](https://www.haproxy.com/solutions/web-application-firewall).
dune73 commented 1 year ago

Thank you for your understanding @NickMRamirez.

This sounds good to me.

@RedXanadu: Anything to add? Otherwise feel free to merge.

RedXanadu commented 1 year ago

Thank you both! This looks perfect @NickMRamirez, thanks for your work on this. Merging now!

@dune73 As we get more vendors and options appearing, we should agree on an ordering. Maybe alphabetical, or sponsors first and then the rest alphabetical. A conversation for another day :slightly_smiling_face:

dune73 commented 1 year ago

Good thinking. I thought that would be a question sooner or later. But now much pressure from integrators to be listed so far.